Adding clock sandcastle example #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mramato
reviewed
Jun 15, 2017
Apps/Sandcastle/gallery/Clock.html
Outdated
| }); | ||
|
|
||
| Sandcastle.addToolbarButton('Slow Down Clock', function() { | ||
| if (viewer.clockViewModel.multiplier > 0) { |
There was a problem hiding this comment.
Can you just change this to divide the value by 2 (and change the speed up to multiply by 2)? It was hard to notice the slowdown/speedup since it starts at 4000 compared to 3900. I would also remove these if checks because they will no longer be needed.
|
Just the one comment. Thanks @rahwang |
|
Thanks @mramato , done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sandcastle example demoing the clock API.
Could you review, @mramato ?