Replaces DeveloperError(s) with Check(s) in Color.js #5424
Conversation
Source/Core/Color.js
Outdated
| } | ||
|
|
||
| Check.typeOf.object('cartesian', cartesian); | ||
|
|
There was a problem hiding this comment.
Throughout, remove any empty lines surrounding the check.
Source/Core/Color.js
Outdated
| @@ -1,12 +1,14 @@ | |||
| /*global define*/ | |||
| define([ | |||
| './Check', | |||
| './defaultValue', | |||
| './defined', | |||
| './DeveloperError', | |||
There was a problem hiding this comment.
You can now remove DeveloperError from the list.
Source/Core/Color.js
Outdated
| //>>includeEnd('debug'); | ||
|
|
||
| Check.typeOf.number.lessThanOrEquals('minimumGreen', minimumGreen, maximumGreen); |
There was a problem hiding this comment.
Throughout, make sure the Check call is between //>>includeStart('debug', pragmas.debug); and //>>includeEnd('debug');. The purpose of those is to mark code that should not be included in the release build.
Source/Core/Color.js
Outdated
| throw new DeveloperError('alpha is required'); | ||
| } | ||
|
|
||
| Check.defined('color', color); |
There was a problem hiding this comment.
Look out for this with the rest of the checks. The one exception is for arrays which should continue to be checked with Check.defined since we don't have a Check.typeOf.array.
There was a problem hiding this comment.
Okay I'll make those changes
Source/Core/Color.js
Outdated
| } | ||
|
|
||
| Check.defined('color', color); | ||
| Check.defined('alpha', alpha); |
There was a problem hiding this comment.
Use Check.typeOf.number.
|
The fixes look good! |
Part of #4794