Expose getStats function in Cesium3DTilesInspectorViewModel #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
reviewed
May 22, 2017
| /** | ||
| * Generates an HTML string of the statistics | ||
| * @param {Cesium3DTileset} tileset The tileset | ||
| * @param {Boolean} isPick Whether this is getting the statistics for a picked feature |
There was a problem hiding this comment.
Looks good to me, I would just change this description to Whether this is getting the statistics for the pick pass
|
@lilleyse ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm overriding the default picking functionality in the
Cesium3DTilesInspectorand I need a way to call this function from my custom view