Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix morph crash from Columbus view to 3D #5312

Merged
merged 5 commits into from
May 18, 2017
Merged

Fix morph crash from Columbus view to 3D #5312

merged 5 commits into from
May 18, 2017

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented May 11, 2017

Fixes #5311.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 11, 2017

Thanks @bagnell. Please update README.md. Is it also possible to add a reasonable unit test?

@cfairchi could you test this?

@bagnell
Copy link
Contributor Author

bagnell commented May 16, 2017

@pjcozzi This is ready. There are no tests for SceneTransitioner.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2017

Am I doing something wrong? If I run

http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/morph-crash/Apps/Sandcastle/index.html?src=Hello%20World.html&label=Showcases

Then morph to CV, I get:

image

@hpinkos
Copy link
Contributor

hpinkos commented May 18, 2017

Looks like it's running into the new DeveloperError I added in #5304

@bagnell
Copy link
Contributor Author

bagnell commented May 18, 2017

Yes, it was from the latest merge. Fixed.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2017

Thanks, looks good!

@pjcozzi pjcozzi merged commit 33165c3 into master May 18, 2017
@pjcozzi pjcozzi deleted the morph-crash branch May 18, 2017 19:52
@pjcozzi pjcozzi mentioned this pull request May 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagnell @pjcozzi @hpinkos