Incremental renderer updates for multiple viewports #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcozzi
reviewed
Apr 20, 2017
Source/Scene/FXAA.js
Outdated
| @@ -54,6 +54,9 @@ define([ | |||
| this._viewport = new BoundingRectangle(); | |||
| this._rs = undefined; | |||
|
|
|||
| this._useScissorTest = undefined; | |||
There was a problem hiding this comment.
Throughout, _useScissorTest is a boolean, right? Initialize it as such, e.g., = false, unless this creates an issue.
|
LGTM. @lilleyse can you review this too? |
|
The cardboard demo is missing one side, otherwise looks good! |
|
@lilleyse Fixed. This is ready for another look. |
|
Good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2D is rendered with either one or two viewports depending on whether the longitude line at 180 degrees is visible. This computes the two viewports from the pass state viewport instead of the canvas dimensions.
All commands that copy from a post process framebuffer now use the scissor test to only copy the portion of the texture written to. The idea is that multiple scenes/viewports can use the same post process resources (textures, fbos, etc.) and just change the render state. The alternative was to create a viewport sized texture for each viewport.