Update orthographic projection width #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
reviewed
Mar 17, 2017
| if (defined(rayIntersection)) { | ||
|
|
||
| if (scene.pickPositionSupported) { | ||
| depthIntersection = scene.pickPositionWorldCoordinates(mousePosition, scratchDepthIntersection); |
There was a problem hiding this comment.
Just wondering, are there other areas that commonly call pickPosition? Caching based on the window coordinates per-frame might not be a bad idea.
There was a problem hiding this comment.
That's a good idea. We could even take it further and cache it for a few frames or more depending on the frame rate, but that's not something I want to explore here.
There was a problem hiding this comment.
Ok, I'll open an issue so we can think about it more.
Source/Scene/Camera.js
Outdated
| if (defined(rayIntersection) && defined(depthIntersection)) { | ||
| var depthDistance = defined(depthIntersection) ? Cartesian3.distance(depthIntersection, this.positionWC) : Number.POSITIVE_INFINITY; | ||
| var rayDistance = defined(rayIntersection) ? Cartesian3.distance(rayIntersection, this.positionWC) : Number.POSITIVE_INFINITY; | ||
| this.frustum.width = depthDistance < rayDistance ? depthDistance : rayDistance; |
|
@lilleyse This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update frustum width by picking the depth buffer. Previously, the width was set by the distance to the globe. This would cause clipping large building models.