3D Tiles - Unloading fix #5008
Merged
3D Tiles - Unloading fix #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! The fix looks good to me. @jbo023 please confirm and we'll merge this. |
|
Ah, thanks, I didn't see the problem anymore. But i didn't have the time to do a deeper test. |
|
Thanks @jbo023, let us know if it comes up again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4673
Having the
t.canRequestContent()check in the loop prevented some tiles from being touched when the request scheduler was full, causing them to be unloaded and continually reloaded.@jbo023 this fixes the original bug you posted. Let me know if it also works from your end.