Fix for VAOs that use constant attributes #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcozzi
reviewed
Feb 13, 2017
Source/Renderer/VertexArray.js
Outdated
| @@ -308,6 +309,10 @@ define([ | |||
| hasInstancedAttributes = true; | |||
| break; | |||
| } | |||
| if (defined(vaAttributes[i].value)) { | |||
| hasConstantAttributes = true; | |||
| break; | |||
There was a problem hiding this comment.
Are you sure this break statement and the one above should be here?
Either split this into a separate for loop or merge into the above and remove all the breaks.
|
Worth an update to CHANGES.md? |
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant attributes set with
glVertexAttrib4fv(and others) are incorrectly treated as part part of VAO state, while they are actually part of the context's state. These attributes need to bound manually whenVertexArrayis bound.Source: https://www.khronos.org/opengl/wiki/Vertex_Specification#Non-array_attribute_values
Discovered through this bug on the forum: https://groups.google.com/forum/#!topic/cesium-dev/F6pMiEdXTcQ
Code example: http://localhost:8080/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=131e3e42d1710f49d0199d9dc8bd3328
Before / after: