Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs: remove test div when finished with it #4925

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jan 26, 2017

Fixes #4923

More than one test was using a div with this id, so when we added this one but forgot to remove it the other tests couldn't add a new div with the same id. That's what was causing the tests to fail when they all ran, but not when they ran individually.

@hpinkos hpinkos changed the title Remove test div when finished with it Fix specs: remove test div when finished with it Jan 26, 2017
@emackey
Copy link
Contributor

emackey commented Jan 26, 2017

Great find, thanks.

@emackey emackey merged commit 84e0a08 into master Jan 26, 2017
@emackey emackey deleted the widget-specs branch January 26, 2017 15:12
@pjcozzi pjcozzi mentioned this pull request Jan 27, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants