3D Tiles in 2D/CV #4884

bagnell · 2017-01-18T22:10:18Z

Add 3D Tiles support for 2D and Columbus View.

The majority of this change was for models using RTC or are positioned in ECF (model matrix is identity). I'll open a PR for those changes in master. @lilleyse Can you create two simple glTF models from the tilesets you made for me for testing?

Add tests.

lilleyse · 2017-01-19T03:15:03Z

Contains local, ecef, quantized, and rtc:

models.zip

pjcozzi · 2017-01-19T19:47:16Z

Add tests.

There's also some new selection/visibility failures in this branch.

pjcozzi · 2017-01-19T19:48:05Z

Apps/Sandcastle/gallery/3D Tiles.html

@@ -30,7 +30,6 @@
 //Sandcastle_Begin

 var viewer = new Cesium.Viewer('cesiumContainer', {
-    scene3DOnly : true,


Remove this from the other 3D Tiles Sandcastle examples.

pjcozzi · 2017-01-19T19:53:17Z

Run http://localhost:8080/Apps/Sandcastle/index.html?src=3D%20Tiles.html&label=Showcases
Switch to 2D
Switch to 3D
In the console:

Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:171:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)
[Color]: Visited: 1, Selected: 1, Commands: 0 | Requests: 0, Attempted: 0, Processing: 0, Content Ready: 5, Total: 5 | Tiles styled: 0, Features styled: 0
Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:171:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)
Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:171:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)
Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:171:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)

pjcozzi · 2017-01-19T19:55:48Z

Run http://localhost:8080/Apps/Sandcastle/index.html?src=3D%20Tiles.html&label=Showcases
Switch to CV
Load Translucent tileset
Then load the top Tileset tileset
Get this exception:

pjcozzi · 2017-01-19T19:57:03Z

Part of #3241

pjcozzi · 2017-01-19T19:59:02Z

The 3D Tiles Batch Table Hierarchy example works in 2D, but not in CV.

pjcozzi · 2017-01-19T20:00:35Z

The 3D Tiles Point Cloud Styling example only works in 3D; the tileset does not show up in 2D or CV.

pjcozzi · 2017-01-19T20:01:58Z

@pmconne - keep an eye on progress here for 3D Tiles in 2D and Columbus View.

pjcozzi · 2017-01-19T20:04:57Z

Source/Scene/Cesium3DTileset.js

+            var sseDenominator = camera.frustum.sseDenominator;
+            error = (geometricError * height) / (distance * sseDenominator);
+
+            if (tileset.dynamicScreenSpaceError) {


Can we still account for this in CV? What about 2D?

I don't think it would make sense in 2D. Maybe CV, but we don't have fog in CV either.

pjcozzi · 2017-01-19T20:05:39Z

@bagnell it would be good to test this with a massive tileset and make sure 2D uses the SSE to not load too many tiles.

pjcozzi · 2017-01-19T20:05:52Z

Just those comments, good start @bagnell.

lilleyse · 2017-01-24T19:18:30Z

Here are some updated models:
gltfs.zip

bagnell · 2017-01-24T21:40:25Z

This is ready for another look. I still need to add tests, but all of the issues mentioned should be fixed.

pjcozzi · 2017-01-25T21:16:44Z

@bagnell is this 100% ready since tests where added in 1f70717?

bagnell · 2017-01-25T21:17:58Z

Yes, the rest of the tests are in #4922.

pjcozzi · 2017-01-25T21:22:40Z

In the 3D Tiles Batch Table Hierarchy example:

Switch to 2D then back to 3D.
The follow exception shows up in the console:

Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:211:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)
Uncaught DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at PerspectiveOffCenterFrustum.computeCullingVolume (http://localhost:8080/Source/Scene/PerspectiveOffCenterFrustum.js:221:20)
    at getPickPerspectiveCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2544:26)
    at getPickCullingVolume (http://localhost:8080/Source/Scene/Scene.js:2552:16)
    at Scene.pick (http://localhost:8080/Source/Scene/Scene.js:2593:36)
    at <anonymous>:211:31
    at handleMouseMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:253:13)
    at handlePointerMove (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:649:13)
    at HTMLCanvasElement.listener (http://localhost:8080/Source/Core/ScreenSpaceEventHandler.js:68:13) (on line 422 of http://localhost:8080/Source/Core/Cartesian3.js)

pjcozzi · 2017-01-25T21:25:12Z

In the 3D Tiles Sandcastle example, the "Instanced" tileset does not show up in 2D and CV.

pjcozzi · 2017-01-25T21:29:44Z

Just those two issues.

bagnell · 2017-01-25T22:22:13Z

@pjcozzi This is ready.

pjcozzi · 2017-01-25T22:28:04Z

Looks good!

bagnell added 6 commits January 17, 2017 15:51

Initial 3d tiles in 2d. Frustum culling and RTC tiles are broken.

aa96644

Fix RTC in 2D/CV. Frustum culling is still broken.

343a0e9

Compute 2D bounding volumes for each 3D tile and use in frustum culling.

dd12045

Remove comment. Dynamic SSE is only for 3D.

32d39db

Merge branch '3d-tiles' into 3d-tiles-2d

0964932

Fix jsHint.

3c8b4f0

pjcozzi mentioned this pull request Jan 19, 2017

BIM roadmap #4678

Open

53 tasks

pjcozzi reviewed Jan 19, 2017

View reviewed changes

pjcozzi mentioned this pull request Jan 19, 2017

3D Tiles Roadmap #3241

Open

pjcozzi reviewed Jan 19, 2017

View reviewed changes

Fix content bounding volume in 2D. Do not pick when morphing.

9b6188a

bagnell added 4 commits January 24, 2017 14:36

Fix distance to bounding sphere.

b889a8e

Add 2D/CV support for point clouds.

a093dc8

Fix jsHint error.

d3b7707

Fix for RTC center is the origin.

a85a1c6

bagnell mentioned this pull request Jan 25, 2017

RTC and ECEF models in 2D/CV #4922

Merged

Add 3D tiles tests for rendering in 2D and CV.

1f70717

Do not pick while morphing.

7d8efa5

bagnell added 2 commits January 25, 2017 17:19

Add one time warning for instanced models in 2D/CV.

f46ae83

Merge branch '3d-tiles' into 3d-tiles-2d

6b81c81

pjcozzi merged commit 8919284 into 3d-tiles Jan 25, 2017

pjcozzi deleted the 3d-tiles-2d branch January 25, 2017 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3D Tiles in 2D/CV #4884

3D Tiles in 2D/CV #4884

bagnell commented Jan 18, 2017 •

edited

Loading

lilleyse commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi Jan 19, 2017

bagnell Jan 24, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

lilleyse commented Jan 24, 2017

bagnell commented Jan 24, 2017

pjcozzi commented Jan 25, 2017

bagnell commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

bagnell commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

3D Tiles in 2D/CV #4884

3D Tiles in 2D/CV #4884

Conversation

bagnell commented Jan 18, 2017 • edited Loading

lilleyse commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi Jan 19, 2017

Choose a reason for hiding this comment

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

pjcozzi Jan 19, 2017

Choose a reason for hiding this comment

bagnell Jan 24, 2017

Choose a reason for hiding this comment

pjcozzi commented Jan 19, 2017

pjcozzi commented Jan 19, 2017

lilleyse commented Jan 24, 2017

bagnell commented Jan 24, 2017

pjcozzi commented Jan 25, 2017

bagnell commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

bagnell commented Jan 25, 2017

pjcozzi commented Jan 25, 2017

bagnell commented Jan 18, 2017 •

edited

Loading