Write to gl_FragData instead of gl_FragColor for debug commands if MRT is used #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinEng
force-pushed
the
oitFrustumsCrash
branch
from
9578b57 to
b434bb7
Compare
|
Since this is a user-facing change, please update CHANGES.md. Look at example throughout that file for how to word this. |
pjcozzi
reviewed
Jan 14, 2017
| if (scene.debugShowCommands) { | ||
| if (!defined(command._debugColor)) { | ||
| command._debugColor = Color.fromRandom(); | ||
| } | ||
| var c = command._debugColor; | ||
| newMain += ' gl_FragColor.rgb *= vec3(' + c.red + ', ' + c.green + ', ' + c.blue + '); \n'; | ||
| if (length) { |
There was a problem hiding this comment.
Here and below, we are usually more explicit, e.g., length > 0
|
@bagnell could you do the final review and merge? |
austinEng
force-pushed
the
oitFrustumsCrash
branch
from
7d0f968 to
3dc24ba
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (1) of #2448