update Matrix3 to use Check #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shehzan10
requested changes
Jan 9, 2017
| throw new DeveloperError('array is required'); | ||
| } | ||
| Check.typeOf.object(value, 'value'); | ||
| Check.typeOf.object(array, 'array'); |
There was a problem hiding this comment.
This would be Check.defined(array, 'array');
Also for all other arguments below that are of type arrays.
lilleyse
reviewed
Jan 9, 2017
| Check.typeOf.number(index, 'index'); | ||
| Check.numeric.minimum(index, 0); | ||
| Check.numeric.maximum(index, 2); | ||
| Check.typeOf.object(result, 'result'); |
There was a problem hiding this comment.
Can you reorder so that index is checked before cartesian.
|
Thanks @austinEng for you first PR! |
|
Congrats @austinEng on your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4794