Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard WMS 1.3 Support #4824

Merged
merged 4 commits into from
Jan 10, 2017
Merged

Add Standard WMS 1.3 Support #4824

merged 4 commits into from
Jan 10, 2017

Conversation

cwgrant
Copy link
Contributor

@cwgrant cwgrant commented Jan 9, 2017

For WMS 1.3, use CRS query string parameter to request projection. SRS is still used for older versions. Some implementations of WMS are backwards compatible but CRS is consistent with specification (http://www.opengeospatial.org/standards/wms).

Note that CRS:84 is used for the CRS label rather than EPSG:4326 to preserve lon,lat ordering.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 9, 2017

Thanks @cwgrant! We'll try to review this soon.
In the meantime, can you please send over a Contributor License Agreement? We'll need that before we can merge this pull request. Thanks!

Looks like we received your CLA so this is ready to be reviewed. Thanks!

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 9, 2017

Thanks again, @cwgrant, this looks nicely done!

@kring do you have time to review this?

@cwgrant
Copy link
Contributor Author

cwgrant commented Jan 9, 2017

CLA sent in - let me know if there are any issues.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 10, 2017

@tfili are you familiar with this part of WMS? Perhaps you could also review this?

@tfili
Copy link
Contributor

tfili commented Jan 10, 2017

Thanks @cwgrant. Looks good to me.

@tfili tfili merged commit d1b7b1c into CesiumGS:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants