Tilted CV view and adjust transition from 2D to CV #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated. |
|
@ggetz can you please merge in master and I'll test and merge? |
|
@pjcozzi Merged! |
|
@ggetz did you mean to delete your update to CHANGES.md? I will update it. |
|
The new morph is good with me. |
No, that was an accident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3878.
Columbus view now has a tilt and the animation from 2D to CV has been updated.
Based on the PR by @JoshuaStorm in #3983. I followed his camera setup for CV, but updated the transition to be smoother and crashes no longer happen when transitioning.
There is a slight jump in the transition from CV back to 2D, but that is the current behavior in master. I believe it is from the FOV switch from perspective to orthographic.