Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug with the textures when the rectangle is rotated #4430

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

jorpiell
Copy link

I've detected problems with the textures of a rectangle when it is rotated (#2737). This pull request fixes (at least) all the use cases where the rotation fails

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 15, 2016

Thanks for the pull request, @jorpiell!

Can you please send in a CLA so that we can review this? Let me know if you have any questions.

@jorpiell
Copy link
Author

CLA signed and sent, @pjcozzi

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 17, 2016

Thanks @jorpiell, we received your CLA.

@bagnell can you please review this?

@bagnell
Copy link
Contributor

bagnell commented Oct 18, 2016

Thanks for the fix @jorpiell! I'll update CHANGES.md and add you to CONTRIBUTORS.md in master.

@bagnell bagnell merged commit 5278cdf into CesiumGS:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants