-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D Tiles - Point Cloud Styling #4336
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
41fc014
pnts shader styling
lilleyse 46d00e3
Merge branch '3d-tiles' into pnts-styling
lilleyse 8e98836
Organization
lilleyse b7c2dfd
Rearrange shader construction
lilleyse cc1c4e6
Reorganize parameters and support ARRAY type
lilleyse 5cb1088
Change conditions from an object to an array
lilleyse 758ebb2
Change how result params are used
lilleyse 9d2838e
Stricter type comparisons
lilleyse 096b15b
Reset scratch index for Expression.evaluate
lilleyse 976f32f
Fix tests
lilleyse 953f9be
Merge branch '3d-tiles' into pnts-styling
lilleyse 1fd4b27
Calculate literal colors right away
lilleyse dbd681d
Limit array length
lilleyse 75beb23
Added Point Cloud Styling sandcastle
lilleyse 72ee217
Add back TODO
lilleyse 88903d5
More detailed shader error messages, removed type-checking errors in …
lilleyse 62ecd50
Revert ExpressionSpec
lilleyse 7754b66
Reorganzation of styleContent
lilleyse cab3705
Add BATCH_ID comment
lilleyse 464cee8
Added ability to style based on POSITION, COLOR, and NORMAL semantics
lilleyse 18be9d6
Support DOUBLE, INT, and UNSIGNED_INT point cloud style properties
lilleyse 079d6f6
Added tests
lilleyse 6d8a879
Tweak test for OIT
lilleyse 84d8ff7
Log warning for float conversion
lilleyse a217024
Style point size
lilleyse 55cf834
Change === to == and !== to !=
lilleyse 8823472
Rename size to pointSize
lilleyse c04ff78
Support both === and !==
lilleyse f0f86ad
Merge branch '3d-tiles' into pnts-styling
lilleyse 83efc1b
Fix styling edge case
lilleyse 45d96d8
Merge branch '3d-tiles' into pnts-styling
lilleyse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"color" : "color('red')", | ||
"show" : "${id} < 100" | ||
"show" : "${id} < 100", | ||
"size" : "${id} / 100" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call this
size
? Why not call it precisely what it is:pointSize
, and in the reference doc explain that it defines the point size in pixels when styling point cloud tiles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was a generic name would be good for other sizeable things thing billboards. If fine with either way.