Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeline touch #4305

Merged
merged 2 commits into from
Sep 15, 2016
Merged

Fix timeline touch #4305

merged 2 commits into from
Sep 15, 2016

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Sep 9, 2016

Replaces #4286

_handleTouchMove was an old function that was removed (commit 1b1dea5).

Replacing with _onTouchMove allows the touch to work on the timeline.

To experience this bug:

  1. Go to http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Hello%20World.html&label=Showcases
  2. Using touch (or an emulation in Chrome), touch the timeline bar (make sure it's touch, not a mouse).
  3. Uncaught TypeError: timeline._handleTouchMove is not a function.

Here's how you can emulate touch on a desktop in Chrome

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 9, 2016

@hpinkos can you please update CHANGES.md?

@lilleyse can you test this on the iPad when you have a minute?

@hpinkos
Copy link
Contributor Author

hpinkos commented Sep 12, 2016

@lilleyse ready

@lilleyse
Copy link
Contributor

Works for me.

@hpinkos
Copy link
Contributor Author

hpinkos commented Sep 15, 2016

@lilleyse anything else or is this good to be merged?

@lilleyse lilleyse merged commit 3e530c7 into master Sep 15, 2016
@lilleyse lilleyse deleted the fix-timeline-touch branch September 15, 2016 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants