Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render shadows in 2D and CV #4085

Merged
merged 3 commits into from
Jul 5, 2016
Merged

Don't render shadows in 2D and CV #4085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2597e53
Don't render shadows in 2D and CV
lilleyse Jul 5, 2016
bafe519
Updated CHANGES.md
lilleyse Jul 5, 2016
cdda286
Wording
lilleyse Jul 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Change Log
==========

### 1.24 - 2016-08-01

* Fixed a crash that would occur when switching to 2D view when shadows are enabled. [#4051](https://github.com/AnalyticalGraphicsInc/cesium/issues/4051)

### 1.23 - 2016-07-01

* Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion Source/Scene/Scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,7 +2140,7 @@ define([
var shadowMaps = frameState.shadowMaps;
var length = shadowMaps.length;

frameState.shadowHints.shadowsEnabled = (length > 0) && !frameState.passes.pick;
frameState.shadowHints.shadowsEnabled = (length > 0) && !frameState.passes.pick && (scene.mode === SceneMode.SCENE3D);
if (!frameState.shadowHints.shadowsEnabled) {
return;
}
Expand Down