Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a velocity vector as the aligned axis of a billboard in CZML #4046

Merged
merged 7 commits into from
Jul 14, 2016

Conversation

shunter
Copy link
Contributor

@shunter shunter commented Jun 24, 2016

Introduce a new CZML property velocityReference which indicates that a value is determined by the velocity of an object's position, expressed using reference syntax. The reference can be to any object.

additionally:

  • I clarified in several places that aligned axis must be a unit vector.
  • As discussed offline, I made the vector normalization done by VelocityVectorProperty optional (default remains as before).

Specifically, consider whether this name is what we want. Given that it becomes part of the CZML spec, decisions are fairly permanent here.

"billboard" : {
    "alignedAxis" : {
        "velocityReference" : "#position"
    }
}

For this PR, there is a lot of churn in the validation document. My initial simplistic approach to producing unique packet IDs and unique values etc. caused everything to get re-numbered throughout the document. I have switched it to scope unique values a bit better from now on, so that adding a new property (e.g. velocityReference) won't affect quite as much of the document in the future.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 8, 2016

Who is the right person to review this?

Perhaps @tfili?

@mramato
Copy link
Contributor

mramato commented Jul 11, 2016

@shunter please update CHANGES.md

@mramato
Copy link
Contributor

mramato commented Jul 11, 2016

Other than that, this is fine with me. Can you merge in master, it looks like there are some changes part of this PR that I think should already be merged (czml validation stuff)

@shunter
Copy link
Contributor Author

shunter commented Jul 13, 2016

Updated.

@mramato
Copy link
Contributor

mramato commented Jul 14, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants