added zoom algorithm that better maintains target point in 3D

[e-andersson]

Submitting PR against master instead of 3d-tiles as per request from @bagnell in #3924.

[pjcozzi]

Thanks again, @e-andersson! Can you please update CHANGES.md? This will be released in Cesium 1.23 on July 1.

The test coverage isn't great because there are code paths that only run when terrain is picked.

@bagnell can we programmatically pick terrain? Or extract or mock something to test this block?

[e-andersson]

@pjcozzi CHANGES.md updated now!

[pjcozzi]

@e-andersson can you also merge in master? There is probably a minor conflict in CHANGES.md.

[pjcozzi]

@bagnell is anything else needed here?

@bagnell can we programmatically pick terrain? Or extract or mock something to test this block?

[e-andersson]

@pjcozzi Ah, I intended to but forgot it.

[pjcozzi]

@e-andersson can you please merge in master? Sorry, there is another conflict.

@bagnell is this ready to merge? Is it possible to better test this? I would like to get this into 1.23.

[e-andersson]

Will have a look at it this evening.
On 23 Jun 2016 1:21 p.m., "Patrick Cozzi" [email protected] wrote:

@e-andersson https://github.com/e-andersson can you please merge in
master? Sorry, there is another conflict.

@bagnell https://github.com/bagnell is this ready to merge? Is it
possible to better test this? I would like to get this into 1.23.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4016 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/API5l2eEn_-RjffS-9m4qkLv10t_yGQhks5qOmw3gaJpZM4IyvFx
.

[bagnell]

@pjcozzi This is ready to merge. I'm not sure of a good way to test where the terrain is picked. We should create an issue to add tests everywhere Camera and ScreenSpaceCameraController picks terrain.

[e-andersson]

@pjcozzi merged in master, sorry I couldn't do it sooner.

[pjcozzi]

New functionality looks great, thanks again @e-andersson!