Move logic for real-time mode (SYSTEM_CLOCK) into Clock itself. #4007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYSTEM_CLOCK implies animating forward at a 1x multiplier. Centralize the logic for dealing with coordinating clock settings in Clock itself. When switching to SYSTEM_CLOCK, other values are immediately updated to be consistent. When changing other values, e.g. current time or multiplier, SYSTEM_CLOCK is deactivated.
This fixes some inconsistencies in the UI where the logic was not consistent, due to being scattered around. Specifically, when you dragged the timeline while in realtime mode, you ended up in a hybrid state where the mode was still set to SYSTEM_CLOCK and therefore the label in the UI still said "Today" etc.