Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Box, Cylinder and Corridor to CZML #3989

Merged
merged 6 commits into from
Jun 3, 2016
Merged

Add Box, Cylinder and Corridor to CZML #3989

merged 6 commits into from
Jun 3, 2016

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jun 1, 2016

For #3062
Adds support for Box, Cylinder and Corridor to CZML

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 2, 2016

@mramato will you be able to review and merge this during the code sprint?

@mramato
Copy link
Contributor

mramato commented Jun 3, 2016

Please update CHANGES then I'll merge.

I ran sortRequires to fix the formatting of the require block, but other than that, looks great! Thanks.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 3, 2016

@mramato ready

@mramato
Copy link
Contributor

mramato commented Jun 3, 2016

Open an issue in czml-writer for this too (or just add support and open a PR if you want).

@mramato mramato merged commit a42eb41 into master Jun 3, 2016
@mramato mramato deleted the addCzmlEntityTypes branch June 3, 2016 18:48
@hpinkos hpinkos mentioned this pull request Jun 3, 2016
Closed
@lilleyse lilleyse mentioned this pull request Jun 6, 2016
Closed
@shunter shunter mentioned this pull request Jun 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @pjcozzi @mramato