Fix Billboard.computeScreenSpacePosition #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ottom. Also fix the calculation in 2D for labels.
|
@e-andersson can you please test this? We would like to include this in Cesium 1.22 in a few days on June 1? The branch is hosted here: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/billboard-screen-space-position/ |
|
@bagnell update CHANGES.md |
|
@pjcozzi Did some quick testing (Sandcastle + our application) and it appears to work with the changes. |
|
Thanks for testing @e-andersson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3920.
Swap screen space position y coordinate so it increases from top to bottom. Also fix the calculation in 2D for labels.