Shadows - Fix IE test failures #3973
Conversation
|
According to MDN, polygon offset is supported on IE. Is it just broken? Is there a way we can check if polygonOffset works as opposed to checking for IE? It's always better to check for features rather than browsers. |
|
Testing if polygon offset works would be painful; it would require doing some rendering tests up front that might not be reliable and then lead to false negatives on other browsers. I would rather leave this as is, and then expand if IE users run into a lot of problems. |
|
It doesn't pass the conformance test: https://www.khronos.org/registry/webgl/sdk/tests/conformance/rendering/polygon-offset.html?webglVersion=1&quiet=0 The tests do pass on Edge by the way, except like the OSX Chrome issue Edge supports the depth texture extension but fails to create a depth-only fbo. The fallback is already in place in the code, I just have to fix a test to handle that. |
|
Updated. |
| @@ -178,8 +180,16 @@ define([ | |||
| this._outOfViewPrevious = false; | |||
| this._needsUpdate = true; | |||
|
|
|||
| // In IE11 and Edge polygon offset is not functional. | |||
| var polygonOffsetSupported = true; | |||
| // TODO : check for Edge too | |||
There was a problem hiding this comment.
Is this TODO still needed?
There was a problem hiding this comment.
Nope, I removed it.
For #2594
This fixes the tests failures I was seeing in IE. This isn't completely ready because I need to update
FeatureDetectionto check for Edge and test it on Windows 10.The problem was rendering any commands into the shadow map with polygon offset enabled was causing the test to completely fail, even if the test wasn't checking shadows.