Fix GlobeSurfaceTileSpecs #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #3900, `vertexArraysToDestroy` was added as a parameter to `GlobeSurfaceTile.processStateMachine`, but none of the tests actually pass that parameter. This happens to be OK in master because none of the tests end up using the parameter, but in the 3D Tiles branch, the parameter is required and merging in master results in failing tests. Passing in an empty array fixes the issue (since we don't care about destroying the data in the specs), but we might possibly want to actually test that the parameter is being used correctly.
|
I added to the tests to make sure they were the right length. The test Since I added code here, someone else should review this. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #3900,
vertexArraysToDestroywas added as a parameter toGlobeSurfaceTile.processStateMachine, but none of the tests actually pass that parameter. This happens to be OK in master because none of the tests end up using the parameter, but in the 3D Tiles branch, the parameter is required and merging in master results in failing tests.Passing in an empty array fixes the issue (since we don't care about destroying the data in the specs), but we might possibly want to actually test that the parameter is being used correctly.
@bagnell any thoughts here?