Fix failing sun tests with WebGL validation on. #3905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2771.
The framebuffer was incomplete because we render the sun to a texture that is a fraction of the drawing buffer size. For the tests, the size is between 0 and 1. In practice, this will never happen, but I capped the minimum size to 1 for the tests. Since this never failed before, maybe there was an update where the texture width and height must be greater than or equal to 1?