Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing sun tests with WebGL validation on. #3905

Merged
merged 1 commit into from
May 9, 2016
Merged

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented May 9, 2016

For #2771.

The framebuffer was incomplete because we render the sun to a texture that is a fraction of the drawing buffer size. For the tests, the size is between 0 and 1. In practice, this will never happen, but I capped the minimum size to 1 for the tests. Since this never failed before, maybe there was an update where the texture width and height must be greater than or equal to 1?

@mramato
Copy link
Contributor

mramato commented May 9, 2016

I can confirm the tests are fixed. @lilleyse or @pjcozzi can you merge if you're okay with this change. Thanks.

@lilleyse lilleyse merged commit c976592 into master May 9, 2016
@lilleyse lilleyse deleted the sun-tests branch May 9, 2016 21:40
@pjcozzi
Copy link
Contributor

pjcozzi commented May 10, 2016

@bagnell can you add a comment in master about why the min call is there. Also, is there anywhere else that we need this? Sounds like something the post-processing framework will need to support in general.

bagnell added a commit that referenced this pull request May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants