Added graying out for UI options as in #3755 #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't looked too much into it, but you may be able to utilize knockout to achieve something cleaner. If there's no obvious solution, I'm fine with what you have here. |
|
I'll look into it |
|
Updated |
| @@ -144,6 +167,7 @@ | |||
| Cesium.knockout.getObservable(viewModel, 'cascades').subscribe(updateShadows); | |||
| Cesium.knockout.getObservable(viewModel, 'lightSource').subscribe(updateShadows); | |||
| Cesium.knockout.getObservable(viewModel, 'size').subscribe(updateSettings); | |||
| Cesium.knockout.getObservable(viewModel, 'softShadows').subscribe(updateShadows); | |||
There was a problem hiding this comment.
The latest shadows code that you merged in also added this line above, so you can remove this.
|
The dropdowns and check-boxes are still interactive when they should be disabled. |
| if (uiOptions.disable[viewModel.lightSource].indexOf(setting) > -1) { | ||
| viewModel[setting + 'Enabled'] = false; | ||
| } | ||
| else { |
There was a problem hiding this comment.
Small thing, but we usually put the else on the same line.
|
That's all my comments. I like the new approach. |
|
Updated |
|
Awesome this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the changes suggested in #3755 and made the pull request to the correct branch this time.