Soft shadows #3731
Merged
Soft shadows #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -135,6 +136,7 @@ define([ | |||
| //>>includeEnd('debug'); | |||
|
|
|||
| this.enabled = false; | |||
| this._softShadows = defaultValue(options.softShadows, false); | |||
There was a problem hiding this comment.
Can we expose this as a settable option? If it is too painful to make it dynamic, we should at least be able to set it through Scene/Widget/Viewer at construction time.
There was a problem hiding this comment.
It won't work dynamically now as all shadow receivers would need to recompile their shaders, but I can make it public for construction time.
|
If you didn't already, can you please update the shadows roadmap to include looking into other sampling strategies? |
|
Looks good! Just those comments. @bagnell can merge when ready. |
|
Ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2594
I'm using a basic 3x3 filter right now, so the results are alright but nothing special. Also included in this PR is simplifying the shaders a bit for point lights that don't use cube maps.