Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https:// #3707

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Use https:// #3707

merged 1 commit into from
Mar 16, 2016

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Mar 15, 2016

Fixes #3650

@mramato
Copy link
Contributor

mramato commented Mar 15, 2016

Please update changes and mention that all external urls are now https by default and that this will make Cesium work better our of the box for non-server-based applications.

@mramato
Copy link
Contributor

mramato commented Mar 15, 2016

KmlDataSource still has a //maps.google.com link that should be https. You will also need to update a test that checks for it in KmlDataSourceSpec

@mramato
Copy link
Contributor

mramato commented Mar 15, 2016

Just those 2 comments, other than that this looks good. Thanks @TomPed!

@TomPed
Copy link
Contributor Author

TomPed commented Mar 15, 2016

Updated.

mramato added a commit that referenced this pull request Mar 16, 2016
@mramato
Merge pull request #3707 from TomPed/use-https
03191f3 
Use https://
@mramato mramato merged commit 03191f3 into CesiumGS:master Mar 16, 2016
@mramato
Copy link
Contributor

mramato commented Mar 16, 2016

Thanks @TomPed!

@TomPed TomPed deleted the use-https branch March 16, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomPed @mramato