-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw out short polylines #3305
Conversation
@bagnell does the relative epsilon stuff you put in a while ago come into play here, or is this really just a case of the tolerance not being high enough? Related question: Do we always render the polyline if there are only two points or do we end up deduping to 1 point and then throwing it out? |
@mramato we'll throw it out if the polyline only has two points and the points are almost the same |
Fixes #3293 |
Update CHANGES.md. @bagnell can you please review? |
@bagnell this is ready now. |
@mramato Yes, it was changed to check the absolute or relative error. Here it would check the relative error. We need to go through and check all of the epsilon values, but I think we are just fixing them as issues come up. |
Don't throw out short polylines
Should there be a constant with a single epsilon defined somewhere that all of the geometry uses? Should that be user settable? |
And is 10 the right answer, or just a random guess? |
@mramato 10 is a random guess. It's probably small enough, but at some point we should probably figure out what's the smallest distance that's still worth rendering. 6 was definitely too big because you can still see things at that size even without being zoomed in all of the way.
I don't think it would need to be user settable, but having a constant somewhere that all of the geometries use is a good idea. I added a note to #2364 |
Made the epsilon values smaller for
Polylines
,Corridors
andPolylineVolumes
This forum post reported a problem with the
PolylineVolumes