Added BoundingSphere.fromOrientedBoundingBox function #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
force-pushed
the
sphere-from-oriented-box
branch
from
b40f3d2 to
7e4450d
Compare
| @@ -386,6 +388,23 @@ defineSuite([ | |||
| expect(sphere).toEqual(expected); | |||
| }); | |||
|
|
|||
| it('fromOrientedBoundingBox', function() { | |||
There was a problem hiding this comment.
We should have a test for both with and without a result parameter. For example, see https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/Core/Matrix4Spec.js#L175
|
Added the extra tests. |
|
Thanks! |
pjcozzi
added a commit
that referenced
this pull request
Nov 5, 2015
…ted-box Added BoundingSphere.fromOrientedBoundingBox function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple helper function to create a bounding sphere from an oriented bounding box. This will be used by point clouds on the 3d-tiles branch.