Fix when.defer() usage #3152
Merged
Fix when.defer() usage #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that there are a bunch of places in our code where we use `when.defer()` and return the deferred instance instead of its `promise` property. This works in most cases because when's deferred promises are thenable, however they don't have all of when's API, like `always`. This change makes sure we correctly return `deferred.promise` everywhere. It's probably a quirk of the version of when we are using that defers aren't always-able and always isn't part of the A+ spec, so there's no reason to add additional tests for these.
|
Do you want this in 1.15? I'm OK either way. |
|
There's no reason not to take it, but since you are doing the release, it's your call. @tfili ran into this for the website model converter updates, but it's trivial to work around too. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that there are a bunch of places in our code where we use
when.defer()and return the deferred instance instead of itspromiseproperty. This works in most cases because when's deferredpromises are thenable, however they don't have all of when's API, like
always. This change makes sure we correctly returndeferred.promiseeverywhere.It's probably a quirk of the version of when we are using that defers aren't always-able and always isn't part of the A+ spec, so there's no reason to add additional tests for these.