Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more lenient when processing KML coordinates #3124

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Be more lenient when processing KML coordinates #3124

merged 1 commit into from
Oct 23, 2015

Commits on Oct 23, 2015

  1. Be more lenient when processing KML coordinates 

    Our code in master is pretty strict whenprocessing KML, but it turns
out Google will let you pass almost anything and just use zeros (in the
case of single coordinates) or create an object without an geometry (in
the case of linear rings).  This change makes Cesium match that behavior,
event though the spec itself says it's invalid.

I also noticed the Viewer specs had a bug because Viewer itself was listed
in the list of requires (the way our specs work, the thing being tested
has to be in the list of requires and has to be first).  In this case,
because all creation is deferred to the `createViewer` helper, it wasn't
being included.

To test this just run/review the unit tests, they are updated to reflect
the change in functionality.
    @mramato
    mramato committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    a772110 View commit details
    Browse the repository at this point in the history