glTF 1.0 Changes

[tfili]

Don't merge yet

Fixes

• Handle KHR_binary_glTF extension
• 1.0 Spec changes (glTF 0.8 to 1.0 Guide KhronosGroup/glTF#406)
  • mesh.primitive.primitive -> mesh.primitive.mode
  • mesh.primitive.indices are now optional
  • technique.parameter.source -> technique.parameter.node
  • Removed passes from technique
  • Make technique optional. Render gray material if no technique or extension
  • Support extensions for COLLADA common profile techniques
  • Don't load models with extensions we don't support
• Update all sample and test bgltf files to glb except one for testing
• Update MIME type (Register MIME Types KhronosGroup/glTF#412)
• Update CHANGES.md
• Add deprecation warning for CESIUM_binary_glTF
• Add KHR_materials_common model to Sandcastle
• Add tests for KHR_materials_common with coverage. Should include all lighting models.

[pjcozzi]

For #3034

[pjcozzi]

We should mention KHR_binary_glTF in the reference doc.

[pjcozzi]

Just a reminder:

We should mention KHR_binary_glTF in the reference doc.

[tfili]

Where else do you want it mentioned? It is in the doc for the Model constructor and the fromGltf method.

[pjcozzi]

Good start, thanks @tfili.

[tfili]

@pjcozzi This is the PR I wanted you to look at.

[pjcozzi]

How is test coverage?

modelMaterialsCommon needs tests. I would do basic rendering tests with one (or a few) test models with different lighting models and lights, and then unit test modelMaterialsCommon and verify the generated glTF/shaders.

[pjcozzi]

Can we also add a model using KHR_materials_common to Sandcastle for visual testing. It could even replace one of our current models just using the extension.

[pjcozzi]

I think I mentioned this before, but it will require some effort to merge this into the 3d-tiles branch - it won't be too much though. We'll do it right after 1.15.

[pjcozzi]

I get this test failure (Mac/Chrome):

[tfili]

Can we also add a model using KHR_materials_common to Sandcastle for visual testing. It could even replace one of our current models just using the extension.

@pjcozzi I'll do this as soon as we merge my changes into the open source converter. I'm preparing the pull request now.

[tfili]

I get this test failure (Mac/Chrome):

Weird. It works on Windows. I'll look at it.

[pjcozzi]

Update this Sandcastle example: http://localhost:8080/Apps/Sandcastle/index.html?src=CZML%20Model.html&label=CZML

[pjcozzi]

@tfili that is all my comments. I will try to make a more detailed pass through modelMaterialsCommon tomorrow morning.

[tfili]

@pjcozzi I fixed all of them besides the test failure.Looking at that now.

[tfili]

@pjcozzi This should be good to go to look at again. All tests are done. The only thing I have left is the array of textures.

[pjcozzi]

Update the model path for this Sandcastle demo: http://localhost:8080/Apps/Sandcastle/index.html?src=Picking.html&label=All

[pjcozzi]

Update the model path for this Sandcastle demo: http://localhost:8080/Apps/Sandcastle/index.html?src=Picking.html&label=All

I fixed this.

[pjcozzi]

This is good!

[pjcozzi]

Let's merge into 3d-tiles right after we finish everything needed for 1.15.