Make renderState better aware of passState during partialApply. #2824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
RenderState.partialApply
to be more careful of specific changes to the passState that affect the current renderState. It attempts to keep all of the optimizations from the previous implementation except where they were so aggressive as to miss needed state changes.With this change, the functions that apply the state transition between two renderStates are not allowed access to the passState at all. The passState is reconciled separately, and is always considered even if the renderStates were identical.
Looks like test coverage is missing from this area of the code, @pjcozzi said it might be hard to test. Perhaps a mock gl context could be constructed with spy listeners, but that likely won't happen for 1.11.
Fixes #2790
Fixes #2811