Support for Entity.show #2600
Support for Entity.show #2600
Conversation
1. Tests for Entity show/isShowing and events 2. Get rid of `isAvailableAndShowing`, which won't actually be needed in the long run.
1. Update CHANGES and reference documentation. 2. Add support for KML Feature `visibility` element. 3. Make dynamic updates obey Entity.isShowing. 4. Make static material and outline geometry obey Entity.isShowing. 5. Update specs. 6. Add Sandcastle example 7. To support the Sandcastle example, chaned `viewer.zoomTo` and `viewer.flyTo` to be "best effort" functions, rather than failing if any one entity is not displayed. This was both requested on the mailing list and is needed to zoom to a data source on load or with time-dynamic data.
|
Issue 2600? Where's my Cap'n Crunch whistle? |
While it's possible, it would create inconsistency with all other viz.
|
All looks good. |
| child._definitionChanged.raiseEvent(child, 'isShowing', newValue, oldValue); | ||
| } | ||
| } | ||
| entity._definitionChanged.raiseEvent(entity, 'isShowing', isShowing, !isShowing); |
There was a problem hiding this comment.
This may be super old, but whenever you're passing 'isShowing' as a param inside of this function.. aren't you expecting to set the 'isShowing' property on the 'entity' object? The issue this raises is that the entity object only has a 'get' method defined but no set method for 'isShowing'
There was a problem hiding this comment.
The issue occurs when dealing with entities from the CompositeEntityCollection. Its own CompositeEntityCollection.prototype._onDefinitionChanged throws an error whenever " entity._definitionChanged.raiseEvent(entity, 'isShowing', isShowing, !isShowing)" event is raised
There was a problem hiding this comment.
@sceptre12 if you can reproduce this issue/error in a Sandcastle example, please open a new GitHub issue for it.
This change is way less scary than it may look at first, it's just that adding a top-level entity visibility property ended up with small changes throughout the code.
Entity.showwhich is a boolean for easily hiding or showing an entity and its children.Entity.isShowingwhich is a read-only property that indicates if an entity is currently being drawn (i.e. its show property and all ancestor show properties are true). This is mainly used by the visualizers but could be useful for other stuff as well.visibilityelement, which is mapped directly toEntity.show.viewer.zoomToandviewer.flyToto be "best effort" functions, rather than failing if any one entity is not displayed. This was both requested on the mailing and really an oversight on my part when I initial implemented them. For example, before this change a KML Folder would create an entity with no visualization but with children, zooming to the data would fail as soon as it found the folder, now it ignore the folder and zooms to all data that is actually visualized. This was a one line code change, so don't be alarmed by the length of this bullet point.