Fixes 2D/CV lighting issue #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed it is not a complete fix, and is slightly jarring at the end of the morph, but definitely an incremental improvement. Please update the forum post and let them know this will be in 1.7. |
|
This issue has seem to have returned. 2D with the GeoJSON example in master is exhibiting the same bug that this PR originally addressed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1825, at least what was discussed on the forum. You can test with the GeoJSON Sandcastle example in 2D/CV. The code example in #1825 definitely has other issues. The fix is in
phong.glsl. The rest is clean up (varying normals need to be renormalized before use).