Automatic Globe depth texture #2506

bagnell · 2015-02-21T01:14:05Z

Creates an automatic uniform for the depth texture after the globe is rendered.

…hTexture automatic uniform.

pjcozzi · 2015-02-21T18:11:51Z

Source/Renderer/UniformState.js

@@ -203,6 +205,19 @@ define([

        /**
         * @memberof UniformState.prototype
+         * @type {Texture}
+         */
+        globeDepthTexture : {


Just replace this with a regular property. It will be slightly faster and more concise.

pjcozzi · 2015-02-21T18:15:37Z

@chris-cooper just a heads up that this branch may cause some merge conflicts for the postprocess-hook branch.

pjcozzi · 2015-02-21T18:32:16Z

Source/Scene/Scene.js

+    function destroyTextures(scene) {
+        scene._colorTexture = scene._colorTexture && !scene._colorTexture.isDestroyed() && scene._colorTexture.destroy();
+        scene._depthStencilTexture = scene._depthStencilTexture && !scene._depthStencilTexture.isDestroyed() && scene._depthStencilTexture.destroy();
+        scene._depthStencilCopyTexture = scene._depthStencilCopyTexture && !scene._depthStencilCopyTexture.isDestroyed() && scene._depthStencilCopyTexture.destroy();


This is not declared in the constructor function. Why not name it _depthStencilGlobeTest? "Copy" is too generic, especially as we move towards a post-processing framework.

pjcozzi · 2015-02-21T18:44:29Z

I get culling/blending issues in the Geometry and Appearances Sandcastle example (but not on cesiumjs.org). For example, zoom into the corridors near Alaska and they disappear and reappear.

pjcozzi · 2015-02-21T18:45:13Z

Exception on resize:

pjcozzi · 2015-02-21T18:54:09Z

Source/Scene/Scene.js

+                'void main() { gl_FragColor = vec4(texture2D(depthTexture, v_textureCoordinates).r); }\n';
+            scene._copyDepthCommand = context.createViewportQuadCommand(copyDepthFS, {
+                renderState : context.createRenderState(),
+                uniformMap : {},


I think we can just remove this and use the default, right?

bagnell · 2015-03-05T00:04:40Z

I get culling/blending issues in the Geometry and Appearances Sandcastle example

I couldn't reproduce this. Is it the blinking that I showed you?

I figured out that the blinking is caused when the _copyDepthCommand command is executed, but I'm not sure why. Any ideas?

pjcozzi · 2015-03-05T13:51:24Z

On Windows, this happens in Chrome, but not IE and Firefox. All of which support floating-point textures, but only Chrome supports multiple render targets, so perhaps this is an OIT issue when MRT is available. (This didn't happen on Chrome/Mac, which I bet doesn't have MRT, but I have to check).

If I try to disable OIT in the Geometry and Appearances example,

var viewer = new Cesium.Viewer('cesiumContainer', { 
    orderIndependentTranslucency : false,
    infoBox : false });

we crash:

TypeError: Cannot read property 'setColorFramebuffer' of undefined
TypeError: Cannot read property 'setColorFramebuffer' of undefined
at updateFramebuffers (http://localhost:8081/Source/Scene/Scene.js:905:23)
at new Scene (http://localhost:8081/Source/Scene/Scene.js:463:9)
at new CesiumWidget (http://localhost:8081/Source/Widgets/CesiumWidget/CesiumWidget.js:235:25)
at new Viewer (http://localhost:8081/Source/Widgets/Viewer/Viewer.js:342:28)
at startup (:6:14)
at Object.context.execCb (http://localhost:8081/ThirdParty/requirejs-2.1.9/require.js:1636:33)
at Object.Module.check (http://localhost:8081/ThirdParty/requirejs-2.1.9/require.js:870:51)
at Object. (http://localhost:8081/ThirdParty/requirejs-2.1.9/require.js:1111:34)
at http://localhost:8081/ThirdParty/requirejs-2.1.9/require.js:129:23
at http://localhost:8081/ThirdParty/requirejs-2.1.9/require.js:1154:21
Uncaught TypeError: Cannot read property 'setColorFramebuffer' of undefined (on line 325 of http://localhost:8081/Source/Widgets/CesiumWidget/CesiumWidget.js)

pjcozzi · 2015-03-05T14:01:48Z

Have you stepped through the code? Do you know if createFramebuffers is getting called during zoom when the artifact occurs.

Are we somehow reading and writing to the same texture. Have we tried different texture formats? How can we narrow it down?

I couldn't reproduce this. Is it the blinking that I showed you?

Probably, but I couldn't reproduce the blinking in the same way you had it.

mramato · 2015-03-05T16:44:33Z

As discussed offline, I think this branch accidentally fixes #2327 as well. I have no idea why.

While I'm not qualified to review this code, I did notice harsher edges in this branch compared to master. For example, the box geometry demo:

master

this branch.

Conflicts: CHANGES.md Source/Scene/Scene.js

…depth test. Slightly offset billboard z.

Billboard depth

pjcozzi · 2015-05-27T21:11:42Z

With the "add billboard" button, the label shows up in the terrain:

pjcozzi · 2015-05-27T21:15:34Z

Ah, is this because the peak is so steep and it is getting a lower height next to it? Unless you have a simple solution, make a note of this in #2685.

pjcozzi · 2015-05-27T21:17:42Z

Apps/Sandcastle/gallery/Picking.html

@@ -144,6 +144,50 @@
    }, Cesium.ScreenSpaceEventType.MOUSE_MOVE);
 });

+Sandcastle.addToolbarButton('Pick position', function() {


Any idea why we get negative altitudes right at the end of the model?

Yup, its picking the depth plane. The regular pick to see if the model is under the mouse cursor checks a 3x3 pixel region. Picking the position only uses the center pixel.

pjcozzi · 2015-05-27T21:23:05Z

CHANGES.md

 * Added new `PointPrimitive` and `PointPrimitiveCollection`, which are faster and use less memory than billboards with circles.
 * Changed `Entity.point` back-end graphics to use the new `PointPrimitive` instead of billboards.  No change to the `Entity.point` API.
 * Added optional drilling limit to `Scene.drillPick`.
 * Added optional `ellipsoid` parameter to construction options of imagery and terrain providers that were lacking it.  Note that terrain bounding spheres are precomputed on the server, so any supplied terrain ellipsoid must match the one used by the server.
 * Upgraded Autolinker from version 0.15.2 to 0.17.1.
+* Fixed documentation for `Context.drawingBufferHeight` and `Context.drawingBufferWidth`.
+* Added debug option to `Scene` to show the depth buffer information for a specified view frustum slice and exposed capability in `CesiumInspector` widget.
+* Removed `Scene.fxaaOrderIndependentTranslucency`. Use `Scene.fxaa` which is now `true` by default.


Did we talk about this already?

Shouldn't we deprecate this (over one release is fine) so we output the console warning in the setter?

bagnell · 2015-05-27T21:23:38Z

Ah, is this because the peak is so steep and it is getting a lower height next to it?

Right the position of that billboard is actually slightly yo the left of the peak. I'll make a note of it.

pjcozzi · 2015-05-27T21:27:40Z

Source/Scene/Scene.js

         */
-        this.fxaaOrderIndependentTranslucency = true;
+        this.debugShowDepthFrustum = 1;


Should probably be debugShowGlobeDepthFrustum.

Its also used for showing the pick depth buffer.

pjcozzi · 2015-05-27T21:35:06Z

Source/Scene/Scene.js

+         * @default false
+         * @private
+         */
+        this.copyGlobeDepth = false;


Can we add a unit test for this?

How should I test it?

Can't we set it to true and then test for the automatic uniform?

pjcozzi · 2015-05-27T21:41:56Z

This works well enough. Just those minor comments then let's get this merged.

@mramato we should probably do the entity API changes post 1.10.

bagnell · 2015-05-27T23:59:06Z

@pjcozzi This is ready for another look.

Automatic Globe depth texture

bagnell and others added 6 commits February 19, 2015 20:10

Automatic globe depth texture uniform WIP.

42e4b8d

Fix OIT.

75c7b7e

Fix FXAA and texture changed tests.

836525a

Fix picking and multifrustum tests.

e45c6ae

Add path if framebuffer cannot be created. Add test for czm_globeDept…

851f5ba

…hTexture automatic uniform.

Fix doc

f863026

pjcozzi reviewed Feb 21, 2015
View reviewed changes

pjcozzi and others added 6 commits February 28, 2015 09:59

Merge branch 'master' into globe-depth

4234b92

Merge remote-tracking branch 'origin/master' into globe-depth

7a3b72d

Merge remote-tracking branch 'origin/master' into globe-depth

7068771

Merge branch 'master' into globe-depth

ea14b36

Properly clean up textures and fbos in resize.

da896c5

Updates from review and some clean up.

96ec329

bagnell added 7 commits March 9, 2015 16:56

Merge branch 'master' into globe-depth

c517422

Merge branch 'master' into globe-depth

8dd9c45

Fix for disabling OIT at the scene level.

29bffa1

Merge branch 'master' into globe-depth

a0bd017

Move globe depth framebuffers and commands out of Scene.

f9e2ddb

Clean up unused members in Scene.

1951d40

Fix FXAA when OIT is disabled.

0aca330

bagnell and others added 8 commits May 27, 2015 15:17

Merge branch 'master' into globe-depth

6413fbe

Conflicts: CHANGES.md Source/Scene/Scene.js

Fixes after merge from master.

9c188bd

Remove billboard depth test in the vertex shader. Use fixed function …

7f0f8d6

…depth test. Slightly offset billboard z.

Remove owner size attribute for doing manual depth test on labels.

4a362bb

Do not copy the globe depth by default.

8a3773c

Remove owner size attribute from vertex shader.

9e5a39b

Merge pull request #2755 from AnalyticalGraphicsInc/billboard-depth

286e853

Billboard depth

Merge remote-tracking branch 'origin/master' into globe-depth

a28ea65

pjcozzi reviewed May 27, 2015
View reviewed changes

Fixes for CHANGES.md

9d6e86f

pjcozzi reviewed May 27, 2015
View reviewed changes

bagnell and others added 2 commits May 27, 2015 17:28

Use bgltf model and remove commented code in development example.

3e7fe6b

Fix whitespace

8d769c1

pjcozzi reviewed May 27, 2015
View reviewed changes

bagnell added 3 commits May 27, 2015 19:09

Change based on review.

d26e06b

Update CHANGES.md.

fbed6fb

Add unit test for Scene.copyGlobeDepth.

351c802

Merge remote-tracking branch 'origin/master' into globe-depth

73ad525

pjcozzi added a commit that referenced this pull request May 28, 2015

Merge pull request #2506 from AnalyticalGraphicsInc/globe-depth

7ef77c8

Automatic Globe depth texture

pjcozzi merged commit 7ef77c8 into master May 28, 2015

pjcozzi deleted the globe-depth branch May 28, 2015 20:40

emackey mentioned this pull request Jun 11, 2015

Picking causes a double-render #2790

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic Globe depth texture #2506

Automatic Globe depth texture #2506

bagnell commented Feb 21, 2015

pjcozzi Feb 21, 2015

pjcozzi commented Feb 21, 2015

pjcozzi Feb 21, 2015

pjcozzi commented Feb 21, 2015

pjcozzi commented Feb 21, 2015

pjcozzi Feb 21, 2015

bagnell commented Mar 5, 2015

pjcozzi commented Mar 5, 2015

pjcozzi commented Mar 5, 2015

mramato commented Mar 5, 2015

pjcozzi commented May 27, 2015

pjcozzi commented May 27, 2015

pjcozzi May 27, 2015

bagnell May 27, 2015

pjcozzi May 27, 2015

bagnell commented May 27, 2015

pjcozzi May 27, 2015

bagnell May 27, 2015

pjcozzi May 27, 2015

pjcozzi May 27, 2015

bagnell May 27, 2015

pjcozzi May 27, 2015

pjcozzi commented May 27, 2015

bagnell commented May 27, 2015

Automatic Globe depth texture #2506

Automatic Globe depth texture #2506

Conversation

bagnell commented Feb 21, 2015

Choose a reason for hiding this comment

pjcozzi commented Feb 21, 2015

Choose a reason for hiding this comment

pjcozzi commented Feb 21, 2015

pjcozzi commented Feb 21, 2015

Choose a reason for hiding this comment

bagnell commented Mar 5, 2015

pjcozzi commented Mar 5, 2015

pjcozzi commented Mar 5, 2015

mramato commented Mar 5, 2015

pjcozzi commented May 27, 2015

pjcozzi commented May 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bagnell commented May 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented May 27, 2015

bagnell commented May 27, 2015