-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set box-sizing to avoid visual bugs when using bootstrap. #2505
Conversation
Use Web Essentials to 1. Add missing vendor prefixes 2. Remove no longer needed prefixes 3. Run auto-formatter
While I was at it, I cleaned up the CSS using Web Essentials:
|
transform: translate(0, -20%); | ||
visibility: hidden; | ||
opacity: 0; | ||
-webkit-transition: visibility 0s 0.2s, opacity 0.2s ease-in, -webkit-transform 0.2s ease-in; | ||
-moz-transition: visibility 0s 0.2s, opacity 0.2s ease-in, -moz-transform 0.2s ease-in; | ||
-o-transition: visibility 0s 0.2s, opacity 0.2s ease-in, transform 0.2s ease-in; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Opera still use the -o- prefix now that they've switched to Blink? I thought they ended up using the -webkit- prefix as a result. Cesium was never compatible with Presto and the -o- prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure and a quick Google didn't give an answer. We already had the -o-
prefix in a bunch of places, and since by default the tool adds them I figured it was better to be consistent. If you are convinced we don't need them, we should remove them all, including the ones that were already there (and next time I use Web Essentials I'll just tell it we don't care about Opera).
Actually I'm tempted to rip out all vendor prefixes for The tool you're using generates the wrong prefixes. For example, on the |
As I said, I have no problem backing out the |
No hurry to remove the working ones, it's just a pile of old complexity that will only become more obsolete over time. It irks me that automated tools do the "wrong" thing by simply copying the un-prefixed content verbatim into prefixed versions, without taking into account things like vendor-specific syntax differences, or references to other prefixed properties. |
But yes you should leave the old ones in for now I guess. |
When you get right down to it, I trust your judgment. so feel free to remove whatever you like or make any other changes before merging. If there anything you need from me, let me know. |
A while back, Opera switched to the Blink/Chromium engine, and as part of that it inherited the old -webkit- prefixes, and lost the old -o- prefixes. Almost everything Cesium does in CSS is now un-prefixed in modern browsers, so all prefixes may be shed soon.
MS IE did support most of these prefixes at one time, but that time was before IE supported WebGL, so Cesium doesn't need these prefixes. Also added a missing -ms- prefix on user-select.
After much exploring of caniuse and testing in Opera and IE11, this is my current strategy:
It's worth noting that prefixes in general are a legacy system on the web, newer features will use |
Explicitly set box-sizing to avoid visual bugs when using bootstrap.
As discussed in #2479 when using Bootstrap and Cesium together, the default box-sizing model gets changed on us, which created some visual bugs. After this change, there are still visual differences in our widgets when using bootstrap, but the content sizing issues have been fixed.