Make viewerEntityMixin part of Viewer proper #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated `viewerEntityMixin` and moved it's functionality into `Viewer.
…ixin Conflicts: CHANGES.md
|
Sure, I'll review it soon. |
Also fix URL used in WMS Sandcastle example.
|
WMS picking was completely broken, but I fixed that up and this looks good otherwise. Merging. |
kring
added a commit
that referenced
this pull request
Dec 20, 2014
…yMixin Make viewerEntityMixin part of Viewer proper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2315, and part of the larger effort to make data source and entities the de facto top-level API for Cesium, this change deprecates
viewerEntityMixin(making it a noop) and folds all of the existing functionality into Viewer itself.Since it's no longer a mixin, the implementation changed significantly to avoid the abuse of closures and function creation. The end result is a lot cleaner, in my opinion. Rather than try to diff Viewer.js, I would review the file whole-hog as if it were new.