Fixed imagery providers whose rectangle crosses the IDL. #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersection and Rectangle.contains to work across the IDL.
…tly for rectangles crossing the IDL. Replace all instances of east - west because it assumes east > west.
| @@ -460,7 +521,7 @@ define([ | |||
| * @param {Rectangle} rectangle On rectangle to find an intersection | |||
| * @param {Rectangle} otherRectangle Another rectangle to find an intersection | |||
| * @param {Rectangle} [result] The object onto which to store the result. | |||
| * @returns {Rectangle} The modified result parameter or a new Rectangle instance if none was provided. | |||
| * @returns {Rectangle|undefined} The modified result parameter, a new Rectangle instance if none was provided or undefined if there is no intersection. | |||
There was a problem hiding this comment.
Technically a breaking change, but I don't think it is an issue.
There was a problem hiding this comment.
Hmm, actually we should deprecate this (one release before removal is fine) and replace it with a function with a new name.
|
Code in #2195 looks good in Sandcastle now. There's one test failure:
|
|
Looks good otherwise. |
|
@pjcozzi This is ready for another look. |
|
Looks good. |
pjcozzi
added a commit
that referenced
this pull request
Dec 9, 2014
Fixed imagery providers whose rectangle crosses the IDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2195.