GeoJSON defaults #2256
Merged
GeoJSON defaults #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2167 |
This was referenced Nov 5, 2014
| @@ -449,19 +475,156 @@ define([ | |||
| * Creates a new instance and asynchronously loads the provided url. | |||
| * | |||
| * @param {Object} url The url to be processed. | |||
| * @param {Object} [options] An object with the following properties: | |||
| * @param {Number} [options.markerSize] The default size of the map pin created for each point, in pixels. | |||
There was a problem hiding this comment.
It would be helpful to list the defaults here I think.
|
Tests pass, Sandcastle example works nicely, and the code looks reasonable (admittedly I didn't look at the code in excruciating detail). So all good by me other than the one minor comment. I just reviewed this pull request as a whole instead of your other one separately. I'll give others a chance to review if they want before merging. I'll probably use this feature in National Map right away, so thanks for doing it! |
| * Fixed a bug in `PolylineGeometry` that would cause the geometry to be split across the IDL for 3D only scenes. [#1197](https://github.com/AnalyticalGraphicsInc/cesium/issues/1197) | ||
| * Deprecated the `sourceUri` parameter to `GeoJsonDatasource.load`, use `options.sourceUri` instead. |
There was a problem hiding this comment.
This should go in a Deprecated section at the top, I believe.
|
Okay, updates are in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This builds on top of #2255, so review/merge that first
GeoJsonDataSource.load,GeoJsonDataSource.loadUrl, andGeoJsonDataSource.fromUrlthat takes the same set of parameters as above in order to allow basic per-instance styling.sourceUriparameter toGeoJsonDatasource.load, useoptions.sourceUriinstead.waitsForPromise. Also added tests for the new functionality.