Using cosineAndSine to convert to WebMercator. #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @GatorScott |
|
Thanks @fstoner. This is a nice catch and awesome fix. |
|
For the background I mentioned in person, see Slides 39-43 from @kring's talk: http://cesiumjs.org/presentations/Rendering%20the%20Whole%20Wide%20World%20on%20the%20World%20Wide%20Web.pptx |
|
@fstoner no interest in separate |
|
@pjcozzi The sine/cosine are coupled summations at the moment. So we can keep this as one function for now. Perhaps we can optimize further later. |
|
This works, but I can't reproduce the original artifact on my GPU. No worries, I saw the before/after on @fstoner's machine. |
pjcozzi
added a commit
that referenced
this pull request
Sep 2, 2014
Using cosineAndSine to convert to WebMercator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2110 by using a higher precision implementation of the cosine/sine algorithm.