GeoJSON cleanup #1952
Merged
GeoJSON cleanup #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Streamline Sandcastle example 2. Expose basic graphics objects instead of entire entities for default options 3. Add CZML Sandcastle example to the `DataSources` label.
|
Mind if I tweak the new table CSS? |
|
I was counting on it. |
|
Done |
|
Feel free to review and merge it as well @emackey ;) |
|
This needs your new Sandcastle.reset logic. |
|
Nevermind, that's not in master yet. I'll merge this first and then you can fix it in #1956. |
| var key; | ||
| var nameProperty; | ||
| for (key in properties) { | ||
| if (properties.hasOwnProperty(key) && properties[key]) { | ||
| var upperKey = key.toUpperCase(); | ||
| if (upperKey === 'NAME' || upperKey === 'TITLE') { | ||
| var upperKey = key.toLowerCase(); |
There was a problem hiding this comment.
Pointless nitpicking time. Should this be called lowerKey now?
There was a problem hiding this comment.
Not pointless at all, thanks. I made this change because as a rule we always need to go to lower case because some Unicode characters upper case to the same thing.
|
Just 2 comments in the diffs. |
|
ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoJsonDataSourceSandcastle example to show how to apply custom graphics. This will serve as a reference for a newDataSourcetutorial I'll write sometime soon.defaultPoint,defaultLine, anddefaultPolygonfromGeoJsonDataSourcebecause they just aren't very useful.cesium-infoBox-defaultTablethat can be used by data sources to receive default infobox styling. MadeGeoJsonDataSourceuse this class.