Rename DynamicScene to DataSources #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames lots associated objects for 1.0. Everything is broken, will fix in next commit.
|
Okay, CHANGES is updated, this is ready. |
|
Just one more thought, some of these objects will go through further changes as part of 1.0; I didn't want to conflate those changes with renames, so stuff that might go away just go the rename treatment for now. |
mramato
changed the title
Conflicts: CHANGES.md Source/DataSources/ReferenceProperty.js
Conflicts: CHANGES.md
|
Pretty please? |
| viewer.trackedObject = dynamicObject; | ||
| var entity = dataSource.entities.getById(lookAt); | ||
| if (defined(entity)) { | ||
| viewer.trackedObject = entity; |
There was a problem hiding this comment.
Should trackedObject change to trackedEntity to match?
There was a problem hiding this comment.
I think that's a good idea; same for selectedObject. Both will be more clear.
|
Ready for another look. |
|
I fixed a few places that still used the term "object" and switched to "entity" to be consistent. Merging. |
shunter
added a commit
that referenced
this pull request
Jul 8, 2014
Rename DynamicScene to DataSources
|
Thanks for the assist. I plan on doing a doc review/scrub at some point as well (probably before I write tutorials). |
mramato
added a commit
that referenced
this pull request
Jul 8, 2014
Find and replace in #1883 caused some bad pluralization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1727, this renames the
DynamicScenelayer toDataSourcesit also renames many related objects and files. I have to update CHANGES, but this is otherwise ready for review. Due to the large scale renames, I would prefer to get this into master ASAP.Fixed #1727