Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1434 #1729

Merged
merged 6 commits into from
May 21, 2014
Merged

Issue1434 #1729

merged 6 commits into from
May 21, 2014

Conversation

abwood
Copy link
Contributor

@abwood abwood commented May 21, 2014

Fixes #1434. Few occurrences of {Array} remain (e.g., in binarySearch, mergeSort) where the type is ambiguous.

abwood added 5 commits May 21, 2014 09:13
Conflicts:
	Source/Core/GeometryAttribute.js
	Source/Core/GeometryInstanceAttribute.js
	Source/Core/PolylineGeometry.js
	Source/Core/SimplePolylineGeometry.js
	Source/Renderer/Context.js
	Source/Renderer/createShaderSource.js
	Source/Scene/Polygon.js
	Source/Scene/TextureAtlas.js
@@ -450,7 +450,7 @@ define([
* Adds samples as a single packed array where each new sample is represented as a date, followed by the packed representation of the corresponding value.
* @memberof SampledProperty
*
* @param {Array} packedSamples The array of packed samples.
* @param {Packable[]} packedSamples The array of packed samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Number[].

mramato added a commit that referenced this pull request May 21, 2014
@mramato mramato merged commit 8a40c5d into CesiumGS:master May 21, 2014
@shunter shunter mentioned this pull request May 27, 2014
@pjcozzi pjcozzi mentioned this pull request Jun 24, 2014
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document arrays consistently...
4 participants