-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery file upgrades #1415
Gallery file upgrades #1415
Conversation
The new data is already covered by this section of LICENSE.md: ### Public domain data from Natural Earth Free vector and raster map data @ naturalearthdata.com Terms of use: http://www.naturalearthdata.com/about/terms-of-use/
I'm not sure I see a reason for these going into master yet. simple.czml contains CZML properties not currently handled in master (they need to be ported front another branch). While these properties get ignored, it would be confusing for anyone that uses the file as a reference. As for the GeoJSON, where did it come from and do we have the rights to redistribute it? Further more, is it a good example? One that has meta-data in it might be better to use. I've had a Sandcastle example on my to-do for some time (and may finally get to it with the other work I'm doing in the |
Now that you've opened #1417 my above comments are irrelevant 😄 |
The license is already covered by our Natural Earth block in LICENSE.md. See the comments on the git changeset by expanding the I'm open to using better GeoJSON example(s) if you like. Better metadata might be good. |
I'm going to take another pass at simple.czml, some of the new description properties in there are rough around the edges (which is on me, since I'm the one that generated this version). |
Yes, the US states GeoJSON file (which is actually TopoJSON) was generated by me, using the tool at https://github.com/mbostock/world-atlas, which uses the public-domain Natural Earth data. |
We should get this in before the next release, if possible. |
Don't worry @emackey we will definitely have update examples. We may even have totally new ones. Depends on what I can get done in time. At the very least we'll have the existing demos updated with good descriptions and a GeoJSON demo. |
Removed Landsat and added some better descriptions. File is much smaller now.
Some suggested-offline tweaks are done. This is ready. |
Some data file upgrades that have been sitting on other branches for too long.