Merry Christmas #1321
Merged
Merry Christmas #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tContextAttributes
| options.alpha = false; | ||
| } | ||
| options = defaultValue(options, {}); | ||
| options.allowTextureFilterAnisotropic = defaultValue(options.allowTextureFilterAnisotropic, true); |
There was a problem hiding this comment.
In other places we clone the incoming options object before modifying it.
There was a problem hiding this comment.
Updated, but we're really inconsistent about this. I checked a few places before first making this change and we did not clone. We should probably create a helper function for something like
options = clone(options, true);
options = defaultValue(options, {});
|
Ready for another review. Merry christmas and happy new year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merry Christmas @shunter.
This contains the ability to turn off anisotropic texture filtering and define the screen-space error for the central body. Set it to something big like 128 for kicks.
This does not include the ability to set the fragment shader's precision, which makes our shaders violate the GLSL spec anyway. #817