Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to prs that need a CLA signed #12354

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add label to prs that need a CLA signed #12354

wants to merge 8 commits into from

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Dec 2, 2024

Description

The label is helpful when viewing PRs in other Github views. I've been doing this manually to a few PRs but it should be easily automatable

Issue number and link

no issue

Testing plan

Was a label added to this pr when it was not a conditional check? Then we're good

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Dec 2, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

1 similar comment
Copy link

github-actions bot commented Dec 2, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link

github-actions bot commented Dec 2, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link

github-actions bot commented Dec 2, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace
Copy link
Contributor Author

jjspace commented Dec 2, 2024

@siddheshranade I recall you did the initial implementation of the CLA check, any ideas why this is not working? Do re-runs of the workflow pull from the latest version of the script on this branch or from main?

@siddheshranade
Copy link
Contributor

@jjspace I remember facing the same issue. Yes, manual re-runs of the workflow will execute the code in main.

A workaround I remember using was to update cla.yaml to trigger the action on a push instead of pull_request_target:

on:
  push:

This way you don't have to manually re-run the workflow, it triggers on every git push, and executes the code on whichever branch you're pushing to. You can reset this YAML file change once you confirm the label is being set.

Correct me in case I'm wrong about this and I'm happy to look into it more deeply.

@jjspace jjspace requested a review from ggetz December 3, 2024 16:05
@jjspace
Copy link
Contributor Author

jjspace commented Dec 3, 2024

Testing this was annoying but I was able to confirm the route to add labels works and it added the correct one. Thanks for the suggestion to switch to push @siddheshranade, that was helpful but github fills in different environment variables for different events so it was still a pain...
I left the commit history to show how the working code changed but it could probably be condensed down into a single commit. Anyway, i'm done playing with this, if we want it it should work, if not i'll leave that up to @ggetz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants