-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to prs that need a CLA signed #12354
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
1 similar comment
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
@siddheshranade I recall you did the initial implementation of the CLA check, any ideas why this is not working? Do re-runs of the workflow pull from the latest version of the script on this branch or from |
@jjspace I remember facing the same issue. Yes, manual re-runs of the workflow will execute the code in A workaround I remember using was to update
This way you don't have to manually re-run the workflow, it triggers on every Correct me in case I'm wrong about this and I'm happy to look into it more deeply. |
Testing this was annoying but I was able to confirm the route to add labels works and it added the correct one. Thanks for the suggestion to switch to |
Description
The label is helpful when viewing PRs in other Github views. I've been doing this manually to a few PRs but it should be easily automatable
Issue number and link
no issue
Testing plan
Was a label added to this pr when it was not a conditional check? Then we're good
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change