Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTwin Reality Data - add GeoJSON/KML support #12344

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Nov 27, 2024

Description

This is a follow up to #12334 to add support for GeoJSON and KML data types from the Reality Management API.

The implementation should be good to go but the Sandcastle will need updated to the iTwin and data we actually want to use.

  • Updated Sandcastle data

Issue number and link

No issue

Testing plan

  • Check the new iTwin Feature Service sandcastle and make sure all data is loading as expected
    • Confirm the thumbnail loads as expected
    • Confirm all the layer toggles work and that the data always looks good and visible with different sets turned on and off

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from jjhembd November 27, 2024 19:39
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjspace, this looks good overall. I put 2 minor comments.

I guess we want to wait for the final data before merging?

@jjspace
Copy link
Contributor Author

jjspace commented Nov 27, 2024

Thanks for the review @jjhembd!

I guess we want to wait for the final data before merging?

That is correct. The code shouldn't change but I will change the iTwin and specific reality data assets the sandcastle is pointing at before this is ready to merge

@jjspace
Copy link
Contributor Author

jjspace commented Dec 4, 2024

@jjhembd I believe this should be good to go now, please take another look

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjspace, the new data looks really good!

@jjhembd jjhembd added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 7d33049 Dec 4, 2024
9 checks passed
@jjhembd jjhembd deleted the itwin-more-reality-data-types branch December 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants