-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iTwin Reality Data - add GeoJSON/KML support #12344
Conversation
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjspace, this looks good overall. I put 2 minor comments.
I guess we want to wait for the final data before merging?
Thanks for the review @jjhembd!
That is correct. The code shouldn't change but I will change the iTwin and specific reality data assets the sandcastle is pointing at before this is ready to merge |
@jjhembd I believe this should be good to go now, please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjspace, the new data looks really good!
Description
This is a follow up to #12334 to add support for GeoJSON and KML data types from the Reality Management API.
The implementation should be good to go but the Sandcastle will need updated to the iTwin and data we actually want to use.
Issue number and link
No issue
Testing plan
iTwin Feature Service
sandcastle and make sure all data is loading as expectedAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change